Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Sync pyproject.toml with requirements.txt #1150

Conversation

awharrison-28
Copy link
Contributor

@awharrison-28 awharrison-28 commented May 22, 2023

Motivation and Context

This PR ensures that pyproject.toml with requirements.txt are in sync.

Description

  • removed the ^ from pyproject.toml linting dependencies
  • Added >= to requirements.txt

Contribution Checklist

…requirements.txt resulting in varying dependencies
@awharrison-28 awharrison-28 requested review from dluc and mkarle May 22, 2023 17:02
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 22, 2023
dluc
dluc previously requested changes May 22, 2023
Copy link
Collaborator

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkarle could you test build, integration tests etc. using a couple of different virtualenv, older and newer python versions?

mkarle
mkarle previously approved these changes May 22, 2023
@awharrison-28 awharrison-28 changed the title Python: Set pyproject.toml requirements to specific versions Python: Sync pyproject.toml with requirements.txt May 22, 2023
python/pyproject.toml Outdated Show resolved Hide resolved
mkarle
mkarle previously approved these changes May 25, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 31, 2023 18:08
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 31, 2023 18:10
@awharrison-28 awharrison-28 requested review from dluc and removed request for dluc May 31, 2023 18:10
@lemillermicrosoft lemillermicrosoft removed the request for review from dluc May 31, 2023 18:12
@lemillermicrosoft lemillermicrosoft requested review from dluc and removed request for dluc May 31, 2023 18:12
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels May 31, 2023
@awharrison-28 awharrison-28 requested a review from dluc June 2, 2023 19:48
@dluc dluc dismissed their stale review June 7, 2023 22:42

good to go

@lemillermicrosoft lemillermicrosoft merged commit 05d9e72 into microsoft:main Jun 7, 2023
@dluc dluc mentioned this pull request Jun 12, 2023
dluc added a commit that referenced this pull request Jun 12, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (#1365)
* [de74668] Fixing typos (#1377)
* [67aa732] Python: Fix weaviate integration tests (#1422)
* [f60d7ba] Fix functions_view.py (#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (#1349)
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
This PR ensures that pyproject.toml with requirements.txt are in sync.

### Description
- removed the `^` from pyproject.toml linting dependencies
- Added >= to requirements.txt
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
* [e4781e5] Add sample notebook to demo weaviate memory store (microsoft#1359)
* [dae1c16] Python: Added examples of using ChatCompletion models for
skill building in Jupyter Notebooks (microsoft#1242)
* [f4e92eb] fix: Add Azure OpenAI support for
python/08-native-function-inline (microsoft#1365)
* [de74668] Fixing typos (microsoft#1377)
* [67aa732] Python: Fix weaviate integration tests (microsoft#1422)
* [f60d7ba] Fix functions_view.py (microsoft#1213)
* [b2e1548] Python: Multiple results per prompt (incl. streaming)
(microsoft#1316)
* [4c4670a] Using dotenv instead of parsing keys ourselves (microsoft#1295)
* [05d9e72] Python: Sync pyproject.toml with requirements.txt (microsoft#1150)
* [6cbea85] Python: Add additional_metadata field to MemoryRecord and
address TODOs in ChromaMemoryStore (microsoft#1323)
* [8947e68] Weaviate: Fix to be compatible with python 3.8 (microsoft#1349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants