prevent attach failure when db name contains '.' #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a database name along the lines of "WidgetCatalog_v8.3.433" is passed into the script, attach fails at the "v8.3". Rather than deal with trying to properly escape/encode a `[` and `]` around the names, I found that escaping them with quotes behaves as expected.
|
If approved, it isn't a whole lot of effort to apply this change across the various SQL samples - would the preference be to do each in a separate PR or use a single for all of them? |
|
Thanks for the PR jelster! Please submit a single PR with the same code change for the rest of the Dockerfiles when you can. |
|
No problem! I may have some other PR's I could send your direction involving the (UPDATE: I meant start.ps1) scripts -- since the Start.ps1 is pretty much the same do you want to follow this same pattern of creating 1 PR for review of a single sample, then creating separate PR for the rest, or would you prefer me to create a separate commit for each sample and send as a single PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a database name along the lines of "WidgetCatalog_v8.3.433" is passed into the script, attach fails at the "v8.3". Rather than deal with trying to properly escape/encode a
[and]around the names, I found that escaping them with quotes behaves as expected.