Skip to content

Conversation

cbattlegear
Copy link

  • Changed authentication method of script to use standard Run As account as per Azure Automation current best practices.
  • Changed AutoExportBlobRetention to follow same settings format as AutoExport script
  • Significantly changed Readme
    • Added links to current documentation
    • Added more in depth documentation of steps including creating the Azure Automation Account, Storage account, variables, credentials, and adding the script as a runbook
    • Formatted code blocks
    • Added examples on how to add dictionary objects for database:server pairs and server:credential pairs

@trgrie for reference

# Connection Asset Name for Authenticating (Keep as AzureClassicRunAsConnection if you created the default RunAs accounts)
$connectionAssetName = "AzureClassicRunAsConnection";


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove extra line.

Select-AzureSubscription -Current $global:subName;
# Authenticate to Azure with certificate
Write-Verbose "Get connection asset: $connectionAssetName" -Verbose;
$Conn = Get-AutomationConnection -Name $connectionAssetName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Change the uppercase variable names to lowercase for consistency's sake.

Copy link
Contributor

@trgrie trgrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove the extra space and keep the variable names consistent (lowercase and camel case).

…r information messages, added edits suggested in pull request microsoft#199
@perrysk-msft perrysk-msft merged commit 632db6f into microsoft:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants