-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Change authentication and documentation for SQL DB Automated Export script #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y, testing view in github
# Connection Asset Name for Authenticating (Keep as AzureClassicRunAsConnection if you created the default RunAs accounts) | ||
$connectionAssetName = "AzureClassicRunAsConnection"; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Remove extra line.
Select-AzureSubscription -Current $global:subName; | ||
# Authenticate to Azure with certificate | ||
Write-Verbose "Get connection asset: $connectionAssetName" -Verbose; | ||
$Conn = Get-AutomationConnection -Name $connectionAssetName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Change the uppercase variable names to lowercase for consistency's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just remove the extra space and keep the variable names consistent (lowercase and camel case).
…r information messages, added edits suggested in pull request microsoft#199
@trgrie for reference