PHP Code example modernization #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPCS can be used to check & format code. https://github.com/squizlabs/PHP_CodeSniffer
This isn sensible for the simple tutorial style code examples. https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md#23-side-effects
…ment This also improves readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #763 (comment), this modernizes and cleans up the PHP examples.
I tried to improve it in small steps so the changes can be understood each by its own.
This also adds a Composer file and adds the popular code style tool PHPCS as development dependency. This is not necessary but would make it easier in the future to keep the examples clean and modern.
I also added a PHPCS configuration/ruleset file to setup the code style rules.
The coding standard used is PSR-2.
Lastly, an .editorconfig file helps to configure IDEs that support it to format code accordingly.