Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for search selections highlight going backward when the selection wraps to next line #16691

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

e82eric
Copy link
Contributor

@e82eric e82eric commented Feb 9, 2024

Hi, I realized I had a bug in my pull request for search selections where when the highlight is wrapped it causes the selection to select back to start of the current line instead of wrapping to the next line.

PR where I introduced this bug.
#16227

Summary of the Pull Request

SearchSelection_Backward

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DHowett DHowett merged commit bef2340 into microsoft:main Feb 9, 2024
15 checks passed
DHowett pushed a commit that referenced this pull request Feb 21, 2024
… wraps to next line (#16691)

Hi, I realized I had a bug in my pull request for search selections
where when the highlight is wrapped it causes the selection to select
back to start of the current line instead of wrapping to the next line.

PR where I introduced this bug: #16227

(cherry picked from commit bef2340)
Service-Card-Id: 91808626
Service-Version: 1.20
DHowett added a commit that referenced this pull request Apr 22, 2024
…election wraps to next line (#16691)"

This reverts commit b520c80.
DHowett added a commit that referenced this pull request Apr 23, 2024
This wasn't guarded under velocity, and some of the fixes are coming in
too hot to be serviced into 1.20.

Reverts PR #16227 and #16691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants