Improve font related help text #17259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Terminal
zadjii-msft
approved these changes
May 13, 2024
DHowett
approved these changes
May 13, 2024
| @@ -895,6 +895,9 @@ | |||
| <value>Font face</value> | |||
| <comment>Name for a control to select the font for text in the app.</comment> | |||
| </data> | |||
| <data name="Profile_FontFace.HelpText" xml:space="preserve"> | |||
| <value>You can use multiple fonts by separating them with an ASCII comma.</value> | |||
There was a problem hiding this comment.
hmmm can we make this smarter? we can just say "A comma" and then in the code transform anything that looks like a comma into an ASCII comma?
There was a problem hiding this comment.
That would probably make the life in certain languages easier, but I don't believe such a database is being maintained anywhere. We could then only do it for certain languages. Additionally, a Japanese comma, etc., is technically a valid part of a font name.
This reminds me that I should escape font names with quotes or commas in them. Huh.
| @@ -928,7 +931,7 @@ | |||
| <comment>The main label of a toggle. When enabled, certain characters (glyphs) are replaced with better looking ones.</comment> | |||
| </data> | |||
| <data name="Profile_EnableBuiltinGlyphs.HelpText" xml:space="preserve"> | |||
| <value>When enabled, the terminal draws custom glyphs for block element and box drawing characters instead of using the font. This feature only works when GPU Acceleration is available.</value> | |||
| <value>When enabled, the terminal draws custom glyphs for block element and box drawing characters instead of using the font. This feature is unavailable when using Direct2D as the Graphics API.</value> | |||
There was a problem hiding this comment.
i wonder if there is some way we could leverage the preview control to determine with better fidelity what the user will see
DHowett
pushed a commit
that referenced
this pull request
May 17, 2024
DHowett
pushed a commit
that referenced
this pull request
May 17, 2024
A few minor changes to better guide people along new features in 1.21. The font face box gets a sub-text that explains how to add multiple fonts and the builtin glyph toggle now explains its dependence to D3D. (cherry picked from commit 0d39c00) Service-Card-Id: 92546504 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes to better guide people along new features in 1.21.
The font face box gets a sub-text that explains how to add multiple
fonts and the builtin glyph toggle now explains its dependence to D3D.