Advanced Tab Switcher #6732
Advanced Tab Switcher #6732
Conversation
There was a problem hiding this comment.
UX Issues
Downloaded the branch and got to play around with it for a bit. Found a few big UX issues. After they get fixed/resolved, I'll do another sweep and test out accessibility.
Command Palette Inaccessible
After opening the Tab Switcher, I can now only open the Tab Switcher. When I press the Command Palette keybinding, the Tab Switcher opens instead.
Going Backwards on the Tab Switcher
I bound tabSwitcher to ctrl+tab. Pressing tab gets me the next item in the list. But I'd expect pressing ctrl+shift+tab to go to the previous item.
"Search" box
When we're in anchor mode, it feels a bit weird to have a text box appear, but we can't type into it. I'd bet screen readers would make this extra confusing too because it would read the text box, that you can't type into.
Tab Switcher Results Order
I can't figure out the of the results (I think I got into a bad state somehow). I'd expect them to be in order by index though.
Rearranging Tabs
I created a new tab, then dragged it to index 2 (from 4). I somehow ended up with this:
ghost
added
Needs-Author-Feedback
|
Just an idea. Would it be favorable to also include the icons next to the names in the drop down? Maybe a before and after to compare. |
ghost
added
Area-Extensibility
|
Maybe there needs to be a bit more spacing between the "Icon" column and the "Name" column? |
|
Design feedback: (full review in progress) I fricken love that you got the icons figured out. Now we can follow up by letting commands specify the icon too! (not in this PR for sure) I agree that they maybe need a tad bit more spacing. I'm not sure I love the labels for Maybe change the |
ghost
added
Needs-Author-Feedback
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
|
|
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
## Summary of the Pull Request  Adds support for setting a command's `icon`. This supports a couple different scenarios: * setting a path to an image * on `"iterateOn": "profiles"` commands, setting the icon to `${profile.icon}` (to use the profile's icon) * setting the icon to a symbol from [Segoe MDL2 Assets](https://docs.microsoft.com/en-us/windows/uwp/design/style/segoe-ui-symbol-font) * setting the icon to an emoji * setting the icon to a character (what is an emoji other than a character, after all?) ## References * Big s/o to @leonMSFT in #6732, who really did all the hard work here. ## PR Checklist * [x] Closes #6644 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Importantly, the creation of these icons must occur on the UI thread. That's why it's done in a "load the path from json", then "get the actual IconSource" structure. ## Validation Steps Performed see the gif
|
🎉 Handy links: |
ghost
mentioned this pull request
|
Love all the new stuff in 1.3. Great job Russ |
Not sure where this feedback should go, this seems like a reasonable place. I found it distracting to pop up on ctrl+tab every time, so I turned it off. I do find the list of tabs to be valuable, but would prefer it to be accessible with a separate key (I guess that's the |
|
Strongly agree with @simonratner on the Advanced Tab Switcher - when I press ctrl+tab or ctrl+shift+tab, I just want to go to the next/previous tab, not get a modal popup. The Having said that, I thought the implementation of Advanced Tab Switcher was very clean. And since you exposed the You guys rock. Please keep making Windows Terminal great! |
## Summary of the Pull Request  This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect
## Summary of the Pull Request  This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect (cherry picked from commit 22887d7)
Summary of the Pull Request
This PR adds the Advanced Tab Switcher (ATS) to Terminal. It'll work
similarly to VSCode's tab switcher. Because this implementation rides
off a lot of the Command Palette's XAML code, it'll look just like the
Command Palette, and also have support for tab title search.
References
#3753 - ATS Spec
Closes #1502