Console.WriteLine for NetCore Projects #145

jayaranigarg · 2017-04-07T12:49:18Z

No description provided.

msftclas · 2017-04-07T12:49:22Z

@jayaranigarg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

AbhitejJohn · 2017-04-11T06:23:26Z

scripts/Build.ps1

+	$projectPath = Locate-Item -relativePath $project
+
+	Write-Verbose "$msbuild /t:restore -verbosity:quiet $projectPath"
+	& $msbuild /t:restore -verbosity:quiet $projectPath


quiet [](start = 34, length = 5)

can we make this minimal so we know whats going on instead of it looking like its stuck. Might want to change it on top(nuget restore) too.

AbhitejJohn · 2017-04-11T06:25:40Z

scripts/build/TestFx.Settings.targets

@@ -3,6 +3,7 @@
  <PropertyGroup>
    <TestFxRoot Condition="$(TestFxRoot) == ''">..\..\</TestFxRoot>
    <RepoRoot>..\..\</RepoRoot>
+	<CommonRoot>$(TestFxRoot)src\Adapter\Common\</CommonRoot>


CommonRoot [](start = 2, length = 10)

Do we need this?

No..removing

AbhitejJohn · 2017-04-11T06:36:28Z

src/Adapter/PlatformServices.Shared/netstandard1.0/ns10Constants.cs

@@ -3,10 +3,15 @@

 namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices
 {
+#pragma warning disable SA1649 // SA1649FileNameMustMatchTypeName
+
    internal class Constants


Constants [](start = 19, length = 9)

why not just call this file constants.

Changed name to Constants.cs

AbhitejJohn · 2017-04-11T06:37:16Z

src/Adapter/PlatformServices.Shared/netstandard1.0/Services/ns10TraceLogger.cs

@@ -3,6 +3,7 @@

 namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices
 {
+    using System;


using System; [](start = 4, length = 13)

is this needed?

No..removing

AbhitejJohn · 2017-04-11T06:49:42Z

test/UnitTests/PlatformServices.Shared.Unit.Tests/netstandard1.0/ns10FileOperationsTests.cs

@@ -45,7 +51,7 @@ public void LoadAssemblyShouldThrowExceptionIfFileIsNotFound()
        [TestMethod]
        public void LoadAssemblyShouldLoadAssemblyInCurrentContext()
        {
-            var filePath = Assembly.GetExecutingAssembly().Location;
+            var filePath = typeof(FileOperationsTests).GetTypeInfo().Assembly.Location; // Assembly.GetExecutingAssembly().Location;


// Assembly.GetExecutingAssembly().Location; [](start = 88, length = 44)

nit: remove.

AbhitejJohn · 2017-04-11T06:50:03Z

test/UnitTests/PlatformServices.Shared.Unit.Tests/netstandard1.0/ns10FileOperationsTests.cs

@@ -99,7 +105,7 @@ public void CreateNavigationSessionShouldReturnDiaSession()
                    typeof(MockDiaSession).AssemblyQualifiedName,
                    typeof(MockDiaNavigationData).AssemblyQualifiedName);

-                var diaSession = this.fileOperations.CreateNavigationSession(Assembly.GetExecutingAssembly().Location);
+                var diaSession = this.fileOperations.CreateNavigationSession(typeof(FileOperationsTests).GetTypeInfo().Assembly.Location); // Assembly.GetExecutingAssembly().Location);


// Assembly.GetExecutingAssembly().Location); [](start = 139, length = 45)

nit:remove. Here and everywhere else.

AbhitejJohn · 2017-04-11T06:53:24Z

...UnitTests/PlatformServices.Universal.Unit.Tests/PlatformServices.Universal.Unit.Tests.csproj

@@ -35,20 +35,47 @@
    <WarningLevel>4</WarningLevel>
  </PropertyGroup>
  <ItemGroup>
+    <Reference Include="Castle.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Castle.Core.4.0.0\lib\net45\Castle.Core.dll</HintPath>
+      <Private>True</Private>


please remove.

AbhitejJohn · 2017-04-11T06:53:33Z

...UnitTests/PlatformServices.Universal.Unit.Tests/PlatformServices.Universal.Unit.Tests.csproj

    <Reference Include="Microsoft.VisualStudio.QualityTools.UnitTestFramework, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
      <Aliases>FrameworkV1</Aliases>
    </Reference>
+    <Reference Include="Moq, Version=4.7.8.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Moq.4.7.8\lib\net45\Moq.dll</HintPath>
+      <Private>True</Private>


please remove.

AbhitejJohn · 2017-04-11T06:54:50Z

test/UnitTests/PlatformServices.Universal.Unit.Tests/Services/UniversalTestSourceHostTests.cs

-    /// The universal test source host tests.
-    /// </summary>
-    [TestClass]
-    public class UniversalTestSourceHostTests


UniversalTestSourceHostTests [](start = 17, length = 28)

why was this removed?

This moved to shared code.

AbhitejJohn · 2017-04-11T06:57:48Z

Do check if we need changes in test.cmd as well and check E2E. This is a great value add!! :)

codito · 2017-04-12T04:20:42Z

What's the rationale for naming all files ns10 and ns13? Isn't a folder serving the purpose?

codito · 2017-04-12T04:23:18Z

@mayankbansal018 can you take a look please. These changes are similar to the PlatformAbstractions layer in TP.

AbhitejJohn · 2017-04-12T04:59:04Z

@codito : It would be way easier to identify which file we are editing in VS or any other editor.

AbhitejJohn · 2017-04-12T10:08:30Z

@jayaranigarg : Do update the nuspec files as well - removing dotnet folder, adding this new platform service and adding the new Tracer library as a dependency.

…testfx into dev/jagarg/console

AbhitejJohn · 2017-04-13T06:12:35Z

scripts/test.ps1

@@ -49,6 +49,8 @@ $TFT_Configuration = $Configuration
 $TFT_Pattern = $Pattern
 $TFT_Parallel = $Parallel
 $TFT_All = $All
+$TFB_NetCoreContainers =@("MSTestAdapter.PlatformServices.NetCore.UnitTests.dll")


nit: would fit better into the env variables on top where all the other patterns are.

AbhitejJohn · 2017-04-13T06:14:28Z

scripts/test.ps1

-	{
-		Write-Error "Unable to find vstest.console.exe at $vstestPath. Test aborted."
-	}
+	$TPV2VSTestPath = Get-TPv2VSTestPath


nit: local variables start with non-caps.

AbhitejJohn · 2017-04-13T06:15:00Z

scripts/test.ps1

+function Get-TPv2VSTestPath
+{
+    $packagesPath = Locate-PackagesPath
+	$vstestConsolePath = Join-Path -path $packagesPath "Microsoft.TestPlatform.15.0.1\tools\net46\vstest.console.exe"


variable on top please.

This would not work in CDP scenarios where packages do not get copied over.

AbhitejJohn · 2017-04-13T06:16:41Z

test/UnitTests/PlatformServices.NetCore.Unit.Tests/PlatformServices.NetCore.Unit.Tests.csproj

@@ -60,4 +58,9 @@
      <ResolvedCompileFileDefinitions Remove="@(ResolvedCompileFileDefinitions)" Condition="'%(ResolvedCompileFileDefinitions.Filename)' == 'Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions' or '%(ResolvedCompileFileDefinitions.Filename)' == 'Microsoft.VisualStudio.TestPlatform.TestFramework'" />
    </ItemGroup>
  </Target>
+  <Target Name="PostBuild" AfterTargets="PostBuildEvent">
+      <Exec Command="xcopy /Y /I $(TargetDir)..\..\MSTest.CoreAdapter\Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.dll $(TargetDir)" />


AbhitejJohn · 2017-04-13T06:19:10Z

scripts/test.ps1

+			Write-Error "Unable to find vstest.console.exe at $vstestPath. Test aborted."
+		}
+
+		Write-Verbose "$vstestPath $testContainers $additionalArguments /logger:trx"


TPV2 vstest.console does not work? We might just want to use that everywhere for consistency. You can take this in the next PR.

smadala · 2017-04-12T18:11:11Z

test/UnitTests/PlatformServices.NetCore.Unit.Tests/PlatformServices.NetCore.Unit.Tests.csproj

+    <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">$(PackageTargetFallback);portable-net45+win8+wpa81+wp8</PackageTargetFallback>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="..\MSTest.CoreAdapter.TestUtilities\ActionUtility.cs" Link="ActionUtility.cs" />


No need to add cs files in new cs projects.

AbhitejJohn · 2017-04-14T19:54:41Z

Tagging #18 and #19.

Test MetaPackage for .NET core

jayaranigarg added 3 commits April 5, 2017 16:00

Base commit for NetCore Console.WriteLine

dd5dbf5

Current changes.

7c62c5f

Fixing Unit Tests

0e30ecc

msftclas added the cla-not-required label Apr 7, 2017

jayaranigarg added 4 commits April 7, 2017 18:20

Merge branch 'master' into dev/jagarg/console

b4871c1

Adding TestFx.targets to NetCore PS

9c318fc

Performing restore for NetCore Projects using msbuild

e2b2f7a

Merge branch 'master' into dev/jagarg/console

490be62

jayaranigarg requested review from AbhitejJohn and removed request for AbhitejJohn April 10, 2017 13:43

AbhitejJohn reviewed Apr 11, 2017

View reviewed changes

jayaranigarg added 4 commits April 12, 2017 15:51

PR comments and making changes in test.ps1

33eefde

Merge branch 'master' into dev/jagarg/console

ede639e

Merge branch 'dev/jagarg/console' of https://github.com/jayaranigarg/…

d3278da

…testfx into dev/jagarg/console

Resolving build failure

6213c12

Fixing test script

1715d54

AbhitejJohn reviewed Apr 13, 2017

View reviewed changes

AbhitejJohn approved these changes Apr 13, 2017

View reviewed changes

smadala reviewed Apr 13, 2017

View reviewed changes

mayankbansal018 requested review from 035 and mayankbansal018 and removed request for 035 April 13, 2017 10:16

mayankbansal018 approved these changes Apr 13, 2017

View reviewed changes

jayaranigarg added 2 commits April 13, 2017 16:16

Fixing PR comments and build warnings.

20feaff

PR comments

4178c1b

jayaranigarg merged commit 5f8e5a4 into microsoft:master Apr 13, 2017

jayaranigarg deleted the dev/jagarg/console branch December 26, 2017 12:54

singhsarab added a commit to singhsarab/testfx that referenced this pull request Apr 8, 2019

Merge pull request microsoft#145 from singhsarab/MetaPackageCore

7e613a2

Test MetaPackage for .NET core

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Console.WriteLine for NetCore Projects #145

Console.WriteLine for NetCore Projects #145

jayaranigarg commented Apr 7, 2017

msftclas commented Apr 7, 2017

AbhitejJohn Apr 11, 2017 •

edited

Loading

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn Apr 11, 2017

AbhitejJohn Apr 11, 2017

AbhitejJohn Apr 11, 2017

jayaranigarg Apr 12, 2017

AbhitejJohn commented Apr 11, 2017

codito commented Apr 12, 2017

codito commented Apr 12, 2017

AbhitejJohn commented Apr 12, 2017 •

edited

Loading

AbhitejJohn commented Apr 12, 2017

AbhitejJohn Apr 13, 2017

AbhitejJohn Apr 13, 2017

AbhitejJohn Apr 13, 2017

AbhitejJohn Apr 13, 2017

AbhitejJohn Apr 13, 2017

AbhitejJohn Apr 13, 2017

smadala Apr 12, 2017

AbhitejJohn commented Apr 14, 2017

Console.WriteLine for NetCore Projects #145

Console.WriteLine for NetCore Projects #145

Conversation

jayaranigarg commented Apr 7, 2017

msftclas commented Apr 7, 2017

AbhitejJohn Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AbhitejJohn commented Apr 11, 2017

codito commented Apr 12, 2017

codito commented Apr 12, 2017

AbhitejJohn commented Apr 12, 2017 • edited Loading

AbhitejJohn commented Apr 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AbhitejJohn commented Apr 14, 2017

AbhitejJohn Apr 11, 2017 •

edited

Loading

AbhitejJohn commented Apr 12, 2017 •

edited

Loading