Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow test framework to take ownership of the banner #2919

Merged
merged 10 commits into from
May 30, 2024
Merged

Allow test framework to take ownership of the banner #2919

merged 10 commits into from
May 30, 2024

Conversation

Evangelink
Copy link
Member

Fixes #2657

Evangelink
Evangelink commented May 23, 2024
View reviewed changes
Copy link
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll extract some of the refactoring to a different PR

MarcoRossignoli
MarcoRossignoli reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ServerTestHost.cs line 393 we should not create the capability again but reuse the one inside the service provider. To avoid to lose states between instances and have a singleton one for all the executions.

@Evangelink
Merge branch 'main' into custom-banner
fc86d0b 
# Conflicts:
#	src/Platform/Microsoft.Testing.Platform/Hosts/ConsoleTestHost.cs
#	src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs
@Evangelink
Refactoring
6d85116
@Evangelink
Merge branch 'main' into custom-banner
7ee5bd9
@Evangelink
Merge branch 'main' into custom-banner
5fc4cac
@Evangelink
Add acceptance tests
345dde9
@Evangelink
Merge branch 'main' into custom-banner
574a5e3
@Evangelink Evangelink marked this pull request as ready for review May 28, 2024 20:20
MarcoRossignoli
MarcoRossignoli previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good add the list of public capabilities here https://github.com/microsoft/testfx/blob/main/docs/testingplatform/Index.md under the 4 point

@Evangelink Evangelink merged commit e21c99e into microsoft:main May 30, 2024
1 check passed
@Evangelink Evangelink deleted the custom-banner branch May 30, 2024 08:00
@Evangelink Evangelink mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display MSTest banner in runner mode
2 participants
@Evangelink @MarcoRossignoli