Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .nuspec files with new license tag #603

Merged

Conversation

parrainc
Copy link
Contributor

Fixes #601

@jayaranigarg
Copy link
Member

@parrainc : Build is failing with error 'Cannot find file License.txt'.
Few changes that needs to be done:

  1. Rename the License file to License.txt
  2. Make changes in the build script to make sure this license file is dropped to staging directory i.e. something like
	#Copy over license file to staging directory
	$licenseFilePath = Join-Path $env:TF_ROOT_DIR "LICENSE.txt"
	Copy-Item $licenseFilePath $stagingDir -Force

@parrainc
Copy link
Contributor Author

Done. License file was renamed as part of first commit, what i missed was updating the build script to copy the file over staging dir.

@parrainc
Copy link
Contributor Author

parrainc commented Apr 18, 2019

@jayaranigarg just noticed the azure pipelines (TestFx.PR) check throw a few warnings and failed with a unit test project due to same warning: "The package signature file entry is invalid. The central directory header field 'compression method' has an invalid value (8)"

I'm not sure if this have something to do with the nuget version that is being pulled in, but it would help updating the "Pull in NuGet" task given that the minimum version where this nuspec changes are supported is v4.9.2 and the pipeline is pulling v4.5.1.

@jayaranigarg
Copy link
Member

I'm not sure if this have something to do with the nuget version that is being pulled in, but it would help updating the "Pull in NuGet" task given that the minimum version where this nuspec changes are supported is v4.9.2 and the pipeline is pulling v4.5.1.

@parrainc : In this case, consider changing azure-pipelines.yml file to pull in 4.9.2 version.

@jayaranigarg
Copy link
Member

jayaranigarg commented Apr 24, 2019

@parrainc : The build is failing for NetCore PlatformService csproj. This seems to be a known issue .
The above thread should help to unblock the PR.

@parrainc
Copy link
Contributor Author

oh, good to hear (the known issue part). I'm fixing it right away and push it up again.

@jayaranigarg
Copy link
Member

@parrainc : Awesome 🎉 Thank you for your contribution!! Will go ahead and merge the PR.

@jayaranigarg jayaranigarg merged commit e50e638 into microsoft:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<licenseUrl> tag deprecating soon, specify license in the package directly
2 participants