-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated .nuspec files with new license tag #603
Updated .nuspec files with new license tag #603
Conversation
…ues/601-update-license-from-nuspec
@parrainc : Build is failing with error 'Cannot find file License.txt'.
|
Done. License file was renamed as part of first commit, what i missed was updating the build script to copy the file over staging dir. |
@jayaranigarg just noticed the azure pipelines (TestFx.PR) check throw a few warnings and failed with a unit test project due to same warning: "The package signature file entry is invalid. The central directory header field 'compression method' has an invalid value (8)" I'm not sure if this have something to do with the nuget version that is being pulled in, but it would help updating the "Pull in NuGet" task given that the minimum version where this nuspec changes are supported is v4.9.2 and the pipeline is pulling v4.5.1. |
@parrainc : In this case, consider changing azure-pipelines.yml file to pull in 4.9.2 version. |
oh, good to hear (the known issue part). I'm fixing it right away and push it up again. |
@parrainc : Awesome 🎉 Thank you for your contribution!! Will go ahead and merge the PR. |
Fixes #601