Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert.IsTrue() & False() to handle nullable bools #690

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Assert.IsTrue() & False() to handle nullable bools #690

merged 3 commits into from
Sep 15, 2020

Conversation

HeroMaxPower
Copy link
Contributor

@HeroMaxPower HeroMaxPower commented Feb 26, 2020

Description:
An attempt on handling nullable bools for Assert.IsTrue() Assert.IsFalse()

Implemented these overrides and added some tests for them

public static void IsTrue(bool? condition);
public static void IsTrue(bool? condition, string message);
public static void IsTrue(bool? condition, string message, params object[] parameters);
public static void IsFalse(bool? condition);
public static void IsFalse(bool? condition, string message);
public static void IsFalse(bool? condition, string message, params object[] parameters);

Resolves #652

@Haplois Haplois merged commit 2d392c7 into microsoft:master Sep 15, 2020
@HeroMaxPower
Copy link
Contributor Author

Thanks Haplois

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert.IsTrue/IsFalse for nullable booleans
2 participants