-
Notifications
You must be signed in to change notification settings - Fork 138
Upgrade tmp package and refactor json validation functions #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tarunramsinghani
merged 8 commits into
microsoft:master
from
jessehouwing:fix/jsonValidation
Aug 8, 2025
Merged
Upgrade tmp package and refactor json validation functions #508
tarunramsinghani
merged 8 commits into
microsoft:master
from
jessehouwing:fix/jsonValidation
Aug 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve clarity; enhance warning message for deprecated runners with version info.
…ormation Print ? when a version is missing from the manifest.
Only log a warning is none of the packaged task versions support a non-deprecated runner.
Changes the way task.json files are looked up. This fixes a number of scenarios where a task.json would not be detected. This also improves performance since it significantly reduces the number of folders to scan from all child folders to just the contribution folder and its direct children. This enabled checking for supported runner versions across all versions of a task, not logging a warning if an older task version, included for on-premise backwards compatibility, doesn't support a non-deprecated runner when a later version does.
@tarunramsinghani could you have a look at these changes? They'd remove a bunch of warnings from the release of the Azure DevOps Extension Tasks. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
tarunramsinghani
approved these changes
Aug 8, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @tarunramsinghani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the validation process for
task.json
files associated with build task contributions in the extension merger. The validation is now more targeted, robust, and supports backwards compatibility checks across multiple versions of tasks. Additionally, it updates dependencies and increments the package version.Task.json validation improvements
task.json
files after all partials are processed, rather than during asset processing. This enables more accurate and comprehensive validation. [1] [2]validateTaskJson
method with a newvalidateBuildTaskContributions
method, which finds and validatestask.json
files for each build task contribution, including checks for backwards compatibility with previous task versions.validate
andvalidateRunner
functions injsonvalidate.ts
to support passing all matchedtask.json
paths for backwards compatibility detection, and improved runner deprecation warnings to include the task version. [1] [2] [3]Dependency and version updates
tmp
package dependency to version^0.2.4
inpackage.json
.0.21.2
to0.21.3
inpackage.json
.Related to