Finish implementing sourceFileMayBeEmitted, JSON emit #1245
+273
−388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements changes to the emission logic for source files, with particular attention to JSON modules and their output paths. Key changes include:
- Refining the handling of immediately invoked functions in JSON files (printer.go).
- Renaming and updating the helper function for generating output file paths (outputpaths.go).
- Introducing a new host interface and updating the logic for sourceFileMayBeEmitted (emitter.go).
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/printer/printer.go | Adjusts expression emission for JSON files by checking the ScriptKind and avoiding parentheses for certain expressions. |
| internal/outputpaths/outputpaths.go | Renames the helper function to follow Go naming conventions and updates its call site. |
| internal/compiler/emitter.go | Refactors sourceFileMayBeEmitted by introducing a new host interface and adding conditions to decide file emission based on compiler options. |
| @@ -3175,7 +3175,10 @@ func (p *Printer) emitEmptyStatement(node *ast.EmptyStatement, isEmbeddedStateme | |||
| func (p *Printer) emitExpressionStatement(node *ast.ExpressionStatement) { | |||
| state := p.enterNode(node.AsNode()) | |||
|
|
|||
| if isImmediatelyInvokedFunctionExpressionOrArrowFunction(node.Expression) { | |||
| if p.currentSourceFile != nil && p.currentSourceFile.ScriptKind == core.ScriptKindJSON { | |||
There was a problem hiding this comment.
The JSON-specific branch uses a hack comment referencing an undefined parenthesizerRule. Consider refactoring this block to either integrate a proper parenthesizing solution for JSON files or add a more descriptive comment on why the current approach is necessary.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Ah yes, it's that simple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660
I'm not happy with the emit change, but I don't know what the right fix is. Strada did parenthesizing completely differently.