Skip all tests using AMD/UMD/SystemJS #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes all compiler test baselines related to AMD/UMD/SystemJS modes, as those module systems will no longer be supported.
- Deletes error, types, symbols,
.jsand.diffbaseline files for AMD/UMD/SystemJS tests - Cleans up
testdata/baselines/reference/submodule/compilerby removing modules that used legacy module loading - Ensures that future test runs will skip AMD/UMD/SystemJS scenarios entirely
Reviewed Changes
Copilot reviewed 300 out of 2956 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/commentsMultiModuleMultiFile.errors.txt | Removed multi-module comments error baseline |
| testdata/baselines/reference/submodule/compiler/commentsExternalModules2.* | Deleted all ExternalModules2 baselines (types, symbols, errors, diffs, js) |
| testdata/baselines/reference/submodule/compiler/collisionExportsRequireAnd*.{types,symbols,js,diff,errors.txt} | Removed collisionExports* baselines for AMD/UMD/SystemJS |
sheetalkamat
approved these changes
Jun 26, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know we're not going to bring these modes forward. I think it would make sense to just skip all of these wholesale.