Fix addUndefinedForParameter check location #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the location of the addUndefinedForParameter check in the type serialization logic. Previously, the check was incorrectly nested inside a conditional block, causing it to be skipped in certain scenarios where type nodes weren't being reused.
Key Changes
- Moved the
addUndefinedForParameterlogic outside of a conditional block to ensure it always executes when appropriate - Fixed the closing brace placement to match the corrected logic flow
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/checker/nodebuilderimpl.go | Moved addUndefinedForParameter check outside conditional block and fixed brace placement |
| Multiple baseline files | Updated test baselines reflecting corrected type inference for parameters with ` |
weswigham
approved these changes
Aug 19, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when looking at #1600. In Strada, this is unconditional if the type node isn't being reused.