-
Notifications
You must be signed in to change notification settings - Fork 714
Fix three snapshots bugs #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix three snapshots bugs #1633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but fix the errors in tests ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two snapshot-related bugs in the TypeScript compiler port: an ATA caching issue that caused "No project found for file" errors when opening JS files in inferred projects, and a crash when a tsconfig.json extends a non-existent target.
- Adds null safety checks for extended config handling to prevent crashes when config files don't exist
- Fixes ATA cache invalidation by resetting
commandLineWithTypingsFiles
when command line changes - Adds comprehensive test coverage for both bug scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
internal/tsoptions/tsconfigparsing.go | Adds null safety check for extended config result handling |
internal/project/projectcollectionbuilder.go | Adds early returns for missing configs/projects and resets cached typing files |
internal/project/extendedconfigcache.go | Adds null safety for file handle hash calculation |
internal/project/projectcollectionbuilder_test.go | Adds test for config file registry cleanup scenario |
internal/project/project_test.go | Adds test for ATA cache invalidation bug |
internal/project/configfilechanges_test.go | Adds test for missing extended config creation scenario |
"extends"
target doesn't exist