Make inferred project root files stable ordered #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that inferred project root files are maintained in a stable, sorted order rather than being dependent on the order in which files are opened. This change improves consistency and prevents potential type ordering issues that could affect the behavior of the TypeScript compiler port.
- Adds sorting of inferred project files before updating project roots
- Includes a comprehensive test to verify that files opened in any order result in consistent alphabetical ordering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/project/projectcollectionbuilder.go | Adds slices.Sort() call to ensure inferred project files are sorted before updating project roots |
| internal/project/projectcollectionbuilder_test.go | Adds test case that verifies files opened in non-alphabetical order are stored in stable alphabetical order |
DanielRosenwasser
approved these changes
Aug 26, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing inconsistent test failures in #1635, which indicates a FAR logic bug, but I think we want this order to be stable and predictable nonetheless.