Fix error filtering by comment directives for program diagnostics #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing error filtering by comment directives for program diagnostics, specifically ensuring that @ts-ignore and @ts-expect-error directives are respected across all diagnostic sources.
- Extracts comment directive filtering logic into a reusable function
- Applies directive filtering to include processor diagnostics that were previously unfiltered
- Maintains existing behavior for semantic diagnostics while enabling reuse
sheetalkamat
force-pushed
the
commentDirectives
branch
from
ca9cfa2 to
ef2cec5
Compare
gabritto
reviewed
Aug 29, 2025
gabritto
approved these changes
Aug 29, 2025
gabritto
approved these changes
Aug 30, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing filtering mentioned at #1643 (comment)