autoimports nil dereference crash fix #1665
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a nil dereference crash in the autoimports functionality, specifically addressing issue #1661. The changes add null safety checks to prevent crashes when handling optional values during import processing.
- Added nil checks for
declaration.Name()to prevent accessing properties on nil objects - Added nil check for
importClause.NamedBindingsbefore accessing its properties
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gabritto
approved these changes
Sep 2, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1661
Fixes crash in
tryUseExistingNamespaceImportfrom portingtryCastand optional handling