Fix the race with project refernces computations #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR cherry-picks a fix for race conditions with project reference computations from PR #1692. This appears to be related to handling concurrent operations when processing TypeScript project references during build processes.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testdata/baselines/reference/tsbuildWatch/projectsBuilding/when-there-are-8-projects-in-a-solution.js | Test baseline showing build behavior with 8 projects in watch mode |
| testdata/baselines/reference/tsbuildWatch/projectsBuilding/when-there-are-5-projects-in-a-solution.js | Test baseline showing build behavior with 5 projects in watch mode |
| testdata/baselines/reference/tsbuildWatch/projectsBuilding/when-there-are-3-projects-in-a-solution.js | Test baseline showing build behavior with 3 projects in watch mode |
| testdata/baselines/reference/tsbuild/projectsBuilding/when-there-are-8-projects-in-a-solution.js | Test baseline showing build behavior with 8 projects in non-watch mode |
| @@ -0,0 +1,1284 @@ | |||
| currentDirectory::/user/username/projects/myproject | |||
There was a problem hiding this comment.
There's a typo in the PR title: "refernces" should be "references"
Copilot uses AI. Check for mistakes.
jakebailey
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from #1692