Skip to content

Conversation

sheetalkamat
Copy link
Member

Fixes #1664

@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 22:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ignores timestamp update errors in the TypeScript build process, similar to how it's handled in strada. Instead of reporting diagnostic errors when file timestamp updates fail, the code now silently continues with execution.

Key Changes

  • Remove error reporting for timestamp update failures
  • Reorganize logic to only execute additional operations when timestamp updates succeed
  • Update test baselines to remove the timestamp update error message

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/execute/build/buildtask.go Modified to skip error reporting when SetMTime fails and restructured conditional logic
internal/diagnostics/extraDiagnosticMessages.json Removed the "Failed to update timestamp" diagnostic message definition
internal/diagnostics/diagnostics_generated.go Updated generated diagnostics to replace the removed message with a different one
internal/execute/tsctests/tscbuild_test.go Added new test cases for project reference scenarios
Test baseline files Updated to remove timestamp update error messages from expected outputs

@sheetalkamat sheetalkamat added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 0216862 Sep 9, 2025
22 checks passed
@sheetalkamat sheetalkamat deleted the timeStamp branch September 9, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS5074: Failed to update timestamp of file with --build
2 participants