Fix compare LSP positions #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ComparePositions function that was incorrectly comparing the line property twice instead of comparing character positions when lines are equal. Additionally, it updates numerous test baselines to reflect corrected LSP position comparisons in "find all references" and "go to definition" functionality.
- Fixed logical error in LSP position comparison function
- Updated baseline test files to reflect corrected position handling
- Improved accuracy of reference and definition location reporting
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ls/utilities.go | Fixed bug in ComparePositions function - now correctly compares Character field instead of comparing Line field twice |
| testdata/baselines/reference/fourslash/*.baseline.jsonc | Updated test baselines to reflect corrected position comparisons for find all references and go to definition functionality |
|
Forgot to run |
jakebailey
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.