Fix incorrectly encoded "errors" state in buildInfo by querying bind diagnostics #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as they are computed as part of semantic diagnostics and cached
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the "errors" state in buildInfo was incorrectly encoded when bind diagnostics are present but ignored (e.g., when skipLibCheck is enabled). The fix prevents bind diagnostics from being considered when determining if the build has errors for state tracking purposes.
- Removes bind diagnostics check from the
ensureHasErrorsForStatefunction - Adds a test case to verify proper handling of ignored bind diagnostics
- Updates baseline files to reflect the corrected behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/execute/incremental/program.go | Removes the bind diagnostics check from error state determination |
| internal/execute/tsctests/tsc_test.go | Adds test case for bind diagnostics that should be ignored |
| testdata/baselines/reference/tsc/incremental/when-there-is-bind-diagnostics-thats-ignored.js | New baseline file showing expected output for the test case |
jakebailey
approved these changes
Sep 10, 2025
andrewbranch
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.