feat(ls): fix go to definition #1710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgoomar
commented
Sep 11, 2025
| return fh.Content(), true | ||
| } | ||
| return "", false | ||
| return fs.source.FS().ReadFile(path) |
There was a problem hiding this comment.
This fixes issues with being able to get the source map files. It conforms to the fallback mechanism that TypeScript had which was going to the disk - https://github.com/microsoft/TypeScript/blob/release-5.9/src/services/sourcemaps.ts#L147-L151
rgoomar
commented
Sep 11, 2025
rgoomar
commented
Sep 11, 2025
| "gotest.tools/v3/assert" | ||
| ) | ||
|
|
||
| func TestInternalAliasGoToDefinition(t *testing.T) { |
There was a problem hiding this comment.
I specifically added this to have an automated test for functionality that wasn't tested by the baselines.
rgoomar
commented
Sep 11, 2025
jakebailey
reviewed
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These changes made it so I could go to a proper definition. This approach aligns with the way the TypeScript version of the compiler does it using VFS only and VLQ decoding.
Basically we have a situation where we have an import in a
.tsfile likein a directory like
apps/app-onein anindex.tsfile and the@latticehris an alias that should referencepackages/o11yand it does go to thepackages/o11y/dist/*.d.tsfile although not the source file implementationThis gets to the correct file and line position using VLQ decoding like the TS version does.
This is an alternative approach to #1627 in a simpler way reusing existing functionality.