Remove the minimum node version from @typescript/native-preview-* packages #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Sep 11, 2025
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
jakebailey
approved these changes
Sep 11, 2025
|
I think this is fine to do to fix the "package manager doesn't install anything" problem; I did not mean to put the engines in the other packages (they have no code). But note that this doesn't mean the package is going to work outside the engines range. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform-specific packages are currently being published with:
This will prevent the correct architecture's package from automatically installing when running an older version of node. (At least, this happened with
pnpm- not sure if other bundlers use theenginesfield when checkingoptionalDependencies)