Skip to content

Conversation

andrewbranch
Copy link
Member

This was uncovered while trying to migrate an internal team onto tsgo --build.

@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 23:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes an issue with isolated declarations emit for computed property names in interfaces. The change improves handling of computed property names by adding proper validation for interface declarations and type literals when isolated declarations are enabled.

  • Adds validation logic to properly handle computed property names in interfaces and type literals under isolated declarations
  • Implements IsDefinitelyReferenceToGlobalSymbolObject method to check for valid Symbol object references
  • Includes a test case demonstrating enum member usage as computed property names in interfaces

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
enumMemberInterfacePropertyDeclarationEmit.ts New test case demonstrating enum member computed property names in interfaces
transform.go Enhanced computed property name validation for isolated declarations mode
emitresolver.go Added interface method for checking global Symbol object references
emitresolver.go (checker) Implemented logic to validate Symbol object references in computed properties
isolatedDeclarationErrorsClasses.js* Updated baseline files showing improved declaration emit behavior

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this diff might be bogus. The submodule’s copy of this baseline doesn‘t include declaration emit output at all, so it must have been meddled with in some way during generation.

@andrewbranch andrewbranch added this pull request to the merge queue Sep 16, 2025
Merged via the queue into microsoft:main with commit f3f42e7 Sep 16, 2025
22 checks passed
@andrewbranch andrewbranch deleted the bug/isolatedDeclarationsEmit branch September 16, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants