Fix esModuleInterop default in --module node18
#1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a porting error in the TypeScript compiler's module interop behavior. The PR corrects the default value of esModuleInterop when using --module node18, ensuring it properly defaults to true like other Node.js module kinds.
- Fixed missing
ModuleKindNode18case inGetESModuleInterop()function - Updated baseline test files to reflect the corrected behavior with proper import helpers
- Removed diff baselines that are no longer needed due to the fix
Reviewed Changes
Copilot reviewed 101 out of 101 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/core/compileroptions.go | Added ModuleKindNode18 to the switch case that enables esModuleInterop by default |
| testdata/baselines/reference/submoduleAccepted/... | Updated baseline files reflecting the corrected behavior |
| testdata/baselines/reference/submodule/... | Updated baseline files showing proper import helper generation |
jakebailey
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a PR porting error