Revert back to isObjectLiteralType check #1764
Merged
+176
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a change in the type checker to fix issue #1761 related to fresh object literal subtype checking. The change replaces an object flags check with a call to isObjectLiteralType() function.
- Reverts object flags check back to
isObjectLiteralType()function call in the relater - Adds comprehensive test case covering the specific scenario from issue #1761
- Updates test baselines to reflect the corrected type checking behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/checker/relater.go |
Reverts condition from ObjectFlagsFreshLiteral flag check to isObjectLiteralType() function call |
testdata/tests/cases/compiler/freshObjectLiteralSubtype.ts |
Adds test case with object literal subtyping scenario and enables @target: esnext |
testdata/baselines/reference/compiler/freshObjectLiteralSubtype.types |
Updates type inference baselines for the new test case |
testdata/baselines/reference/compiler/freshObjectLiteralSubtype.symbols |
Updates symbol resolution baselines including Math symbol declarations |
jakebailey
approved these changes
Sep 29, 2025
|
Strada also needs this fix too now, after microsoft/TypeScript#62502, right? |
Yes, I'll be putting up a PR. |
ahejlsberg
added a commit
to microsoft/TypeScript
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761.