Skip to content

Port "Fixed crash in hasVisibleDeclarations related to binding elements" #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2025
+8 −1
Merged

Port "Fixed crash in hasVisibleDeclarations related to binding elements" #1820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af169fa
Port "Fixed crash in `hasVisibleDeclarations` related to binding elem…
Andarist Oct 4, 2025
861b52b
fmt
Andarist Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/checker/emitresolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,14 @@ func (r *emitResolver) hasVisibleDeclarations(symbol *ast.Symbol, shouldComputeA
continue
}
if symbol.Flags&ast.SymbolFlagsBlockScopedVariable != 0 {
variableStatement := ast.FindAncestor(declaration, ast.IsVariableStatement)
rootDeclaration := ast.WalkUpBindingElementsAndPatterns(declaration)
if ast.IsParameter(rootDeclaration) {
return nil
}
variableStatement := rootDeclaration.Parent.Parent
if !ast.IsVariableStatement(variableStatement) {
return nil
}
if ast.HasSyntacticModifier(variableStatement, ast.ModifierFlagsExport) {
continue // no alias to add, already exported
}
Expand Down