-
Notifications
You must be signed in to change notification settings - Fork 718
Move tests around to shorter paths #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Notably this does not move baselines around in |
This may be true now, but if we want to keep that invariant in the future, we also need to port the code that checks for duplicates, which I intentionally did not port before. |
Ah, yes, we should make a test which verifies this explicitly.
Those are still separate; it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it will in fact matter, but the idea is that we'll have more test runners (e.g. emit runner) when we port more of the test infra. Then deleting that Runner
interface might interfere with running all the runners in a single Go test.
Are those tests also in the same namespace (in terms of test name)? I can revert that change for sure. |
Actually, I just added to the PR a launch task example. You just have to open a test in the submodule dir, and then it works. |
internal/testutil/runner
->internal/testrunner
TestCompilerBaselinesLocal
->TestLocal
TestCompilerBaselinesSubmodule
->TestSubmodule
TestCompilerBaselinesSubmodule/conformance/globalThisUnknownNoImplicitAny/error
are nowTestSubmodule/globalThisUnknownNoImplicitAny/error
.These should make it simpler to make a generic launch task like we do in Strada.