Fix parsing of enum options #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Mar 15, 2025
haoqixu
commented
Mar 15, 2025
| } else { | ||
| return convertJsonOption(opt.Elements(), value, basePath, propertyAssignment, valueExpression, sourceFile) | ||
| } | ||
| } else if !(reflect.TypeOf(optType).Kind() == reflect.String) { |
There was a problem hiding this comment.
Strada uses a Map as type of enum option and use !isString(opt.type) as condition of this branch. However tsgo use CommandLineOptionKind for CommandLineOption.Kind whose underlying type is string.
There was a problem hiding this comment.
I think this is the bug you referred to in another comment. 🤔 @jakebailey
haoqixu
changed the title
gabrielluizsf
approved these changes
Mar 17, 2025
jakebailey
reviewed
Mar 17, 2025
jakebailey
reviewed
Mar 18, 2025
...tsconfigParsing/reports errors for wrong type option and invalid enum value with json api.js
Outdated
Show resolved
Hide resolved
iisaduan
approved these changes
Mar 18, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertJsonOptionprematurely verified enum options viaisCompilerOptionsValue, bypassingconvertJsonOptionOfEnumTypeand returning string keys instead of proper enum values.In
parseOwnConfigOfJsonSourceFile,onPropertySetmaps the string key fromconvertJsonOptionto the appropriate enum value. However,convertJsonOptionOfListTypedid not handle this translation for list elements.As a result, top-level enum options (e.g., "target") correctly use enum values in the final compiler options, but enum option lists (e.g., "lib") wrongly retain string keys. Additionally, invalid enum values trigger TS5024 errors instead of the intended TS6046.
This PR aligns
tsgowithtscby fixingconvertJsonOptionand removing the conversion fromonPropertySet.