Enable type baselines #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Team is working really hard! Appreciate that 1Milllion+ additions DAMN |
|
This is now passing! |
|
For reference, there are 12464 types baselines, and only 6825 diff files. And that's despite union ordering / member ordering changes. |
gabritto
approved these changes
Mar 14, 2025
|
|
|
I added in a 1,000,000 truncation limit like we previously had, for now. That limits the length to 4MBish. |
RyanCavanaugh
approved these changes
Mar 14, 2025
|
I'm going to quick see if I can port some code to fix the EDIT: with this type printer, I made it worse 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables type baselining. I've modified the diffing to ignore the lines of the type baselines that have to do with node reuse, which we do not yet handle in this codebase.