Add support for SourceMap emit and baselines #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 948 out of 948 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
internal/ast/ast.go:9679
- Consider adding documentation for the new Text() method to clarify its behavior compared to the previous Text field, which will help future maintainers.
func (node *SourceFile) Text() string {
internal/sourcemap/generator.go:23
- [nitpick] Ensure that the renamed 'Generator' type is clearly documented and consistently referenced across the codebase to reduce potential confusion with other generator patterns.
type Generator struct {
jakebailey
reviewed
Apr 8, 2025
internal/sourcemap/util.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| sourceMapCommentRegExp = regexp.MustCompile(`^\/\/[@#] sourceMappingURL=(.+)\r?\n?$`) |
There was a problem hiding this comment.
Eventually we'll want to eliminate these since Go's regex perf is pretty bad.
testdata/baselines/reference/submodule/compiler/commonSourceDirectory.js.map.diff
Show resolved
Hide resolved
jakebailey
approved these changes
Apr 9, 2025
| // !!! Source file from node_modules are not emitted. In Strada, this depends on module resolution and uses | ||
| // `sourceFilesFoundSearchingNodeModules` in `createProgram`. For now, we will just check for `/node_modules/` in | ||
| // the file name. | ||
| if strings.Contains(sourceFile.FileName(), "/node_modules/") { |
There was a problem hiding this comment.
I would suggest using .Pah() here but I assume this is just temporary?
jakebailey
approved these changes
Apr 9, 2025
shinichy
pushed a commit
to shinichy/typescript-go
that referenced
this pull request
Apr 12, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up source map emit to the emitter and enables source map baselines. After some fixes, the few source map diffs seem to be mostly due to missing transforms.
This also makes a minor change to the
ast.SourceFiletype to makeText()a method rather than a field. This was partially done to supportsourcemap.Source, but also to make it easier to access the source file text while debugging as the Go debugger gets confused byTextbeing a field onSourceFilebut a method onNode, which is observed when addingfile.Textas a Watch expression or when referencing it in the Debug console.