Add typesafe sync.Map wrapper #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
internal/collections/syncmap.go:31
- Ensure that the underlying sync.Map's Clear() method is supported in the target Go version. If targeting an older version that lacks Clear(), consider implementing a manual clear using Range and Delete.
s.m.Clear()
jakebailey
commented
Apr 8, 2025
| @@ -0,0 +1,59 @@ | |||
| package collections | |||
There was a problem hiding this comment.
This is here in core so that leaf packages like cachedvfs don't need to import core.
andrewbranch
approved these changes
Apr 8, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a proposal to add this exact type to the stdlib eventually, but I'm finding it increasingly annoying to deal with
anywhen making newsync.Maps.