Handle synthetic tslib and JSX factory imports #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2025
jakebailey
commented
Apr 9, 2025
| @@ -0,0 +1,44 @@ | |||
| --- old.commentsOnJSXExpressionsArePreserved(jsx=react-jsx,module=commonjs,moduledetection=auto).errors.txt | |||
There was a problem hiding this comment.
This is broken because we do not correctly set the module indicators.
jakebailey
changed the title
jakebailey
force-pushed
the
jabaile/jsx-loading-fixes
branch
from
863c22d to
ecc1236
Compare
jakebailey
commented
Apr 9, 2025
Comment on lines
7
to
+8
| ->notAHelper : Symbol(notAHelper, Decl(tslib.d.ts, --, --)) | ||
| - | ||
| +>notAHelper : Symbol(notAHelper, Decl(tslib.d.ts, 0, 12)) |
There was a problem hiding this comment.
Funny, Strada's regex here is bad, while in Corsa we "fixed" this.
andrewbranch
approved these changes
Apr 9, 2025
|
Future TODO: stop using synthetic nodes for this, because we only use them to then plug into module resolution anyway. There's no real reason to use a Node here other than "the code used to work this way and it's not very trivial to change", but changing it will be faster and make the loader lock-free again. |
shinichy
pushed a commit
to shinichy/typescript-go
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765
Fixes #767
This implements import helper and JSX factory import node synthesis and resolution. Since the AST node is immutable, we cannot modify
SourceFile.Imports. This info is now stored on theProgramrather than at special fixed offsets inimportsthat's mutated after parse.This could allow us to reuse ASTs more often, and means we stop having to work around these synthesized imports in other parts of the code (LS features, mainly).
This PR isn't perfect; it turns out we're missing implementations of
moduleDetectionandexternalModuleIndicator, so we're not correctly determining that JSX files are modules because thejsxsetting plays a part in determining if a file is a module (yay).Fixing that will have to be a follow-up PR but that's going to be a lot more invasive. This PR fixes most stuff as it is now.