Fix release build issues #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes release build issues by updating package publishing configuration and enforcing prerelease parameters for release builds.
- Updated package.json to include a publish configuration with public access.
- Added prerelease parameter validation and version formatting logic in Herebyfile.mjs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| _packages/native-preview/package.json | Added publishConfig to set npm access as public. |
| Herebyfile.mjs | Added release flag validation and version formatting. |
andrewbranch
approved these changes
May 22, 2025
jakebailey
commented
May 22, 2025
| if (options.forRelease) { | ||
| // No real semver prerelease versioning. | ||
| // https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions | ||
| assert(options.setPrerelease, "forRelease is true but setPrerelease is not set"); |
There was a problem hiding this comment.
To be clear this is obviously temporary and any stable release would not do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.