Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue in Roslyn MetadataReference Resolver #3367

Closed
jorgerangel-msft opened this issue May 15, 2024 · 1 comment · Fixed by #3519
Closed

Fix Issue in Roslyn MetadataReference Resolver #3367

jorgerangel-msft opened this issue May 15, 2024 · 1 comment · Fixed by #3519
Assignees
@m-nash
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@jorgerangel-msft
Copy link
Contributor

jorgerangel-msft commented May 15, 2024 •
edited
Loading

It seems that the custom metadata resolver that was added to the generator may not be working as expected. Some generated types are still not being resolved correctly, ie. https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/generator/TestProjects/Local/Unbranded-TypeSpec/src/Generated/Models/ModelWithFormat.cs#L15 (System.Uri) should just be generated Uri.

We should investigate if the resolver has a bug, or if it's not correct to use it for this scenario. If so, we will need an alternative to the resolver that doesn't add all the trusted assemblies on disk to the generated project.
@jorgerangel-msft jorgerangel-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label May 15, 2024
@jorgerangel-msft
Copy link
Contributor Author

We can close this issue if adding the reduce method resolves this problem: Azure/autorest.csharp#4530.

@m-nash m-nash self-assigned this Jun 4, 2024
@m-nash m-nash mentioned this issue Jun 4, 2024
Merged
@jorgerangel-msft jorgerangel-msft mentioned this issue Jun 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 11, 2024
@m-nash
Refine perf and api usage around file creation and code writer (#3519)
72c6ada 
Fixes Azure/autorest.csharp#4530
Fixes #3361
Fixes #3367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-nash m-nash

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine perf and api usage around file creation and code writer m-nash/typespec
3 participants
@timotheeguerin @m-nash @jorgerangel-msft