Add the Optional helper class implementation #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ShivangiReja
commented
Jun 6, 2024
Comment on lines
+44
to
+46
| public static bool IsDefined(System.Text.Json.JsonElement value) | ||
| { | ||
| return value.ValueKind != System.Text.Json.JsonValueKind.Undefined; |
There was a problem hiding this comment.
@jorgerangel-msft I believe you have added post processing to prevent inline namespaces. Do you happen to know why it's generating like this? Is there anything I'm missing?
There was a problem hiding this comment.
I'm not sure, I noticed this too hence why I opened #3367 to investigate. We already added the Reduce functionality from Roslyn, so I'm guessing there is an issue with the metadata reference resolver event handler I added.
There was a problem hiding this comment.
Yeah we have this issue because Roslyn now does not know about anything in System.Text.Json dll. It should be resolved if we add more dlls into roslyn's scope
|
API change check API changes are not detected in this pull request. |
jorgerangel-msft
approved these changes
Jun 6, 2024
m-nash
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3508