[http-client-python] Operation with list body type is not generating the List[JSON] overload

[catalinaperalta]

Example typespec definition: https://github.com/Azure/azure-rest-api-specs/blob/141eb6d8c5aa89d50ab1b9a5c29b9c0886d10309/specification/confidentialledger/data-plane/ConfidentialLedger/routes.tsp#L576-L584

Generated code example: https://github.com/Azure/azure-sdk-for-python/blob/c01e7384c190f2de8f62836d0effc09e3b8156f8/sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_operations.py#L3442-L3445

I would expect the List[JSON] overload to still exist even when we move from DPG without models to DPG with models.

cc @iscai-msft

[iscai-msft]

it seems that we're serializing things incorrectly as well when users pass in a list of JSON objects. Here is the error that @catalinaperalta is running into from the service.

I'd expect our types/array test here to have an overload where the input body is list[JSON]. Additionally, we should also add a test here passing in a list of JSON to make sure that the serialization sent to the server is correct. Something like

client.model_value.put(
      [
          {"property": "hello"},
          {"property": "world"},
      ]
  )

[msyyc]

@catalinaperalta
(1) we add overload logic in #8516
(2) about the serialization error, it is not codegen bug but wrong input parameters. If you input JSON directly, you shall follow camel case which is consistent with REST layer. (e.g. https://github.com/Azure/azure-sdk-for-python/blob/940c7a4a6478c0b41e780b58101065a0049954aa/sdk/confidentialledger/azure-confidentialledger/tests/test_confidential_ledger_client.py#L610 shall be client.create_user_defined_role([{"roleName": role_name, "roleActions": ["/content/read"]}])

[catalinaperalta]

I investigated a bit more into the issue. It looks like we're not wrapping the body parameter in this case. If it's a tsp definition issue, I'd appreciate your advice on what I need to change.

Example of the difference in old codegen and new:

Old sdk recording: https://github.com/Azure/azure-sdk-assets/blob/7025cb5b36723eeb371840ea4302552cc393b62b/python/sdk/…
New sdk recording: https://github.com/Azure/azure-sdk-assets/blob/2629e37e48a1fc7c62f21a4be3cc6d71c50a1a5b/python/sdk/…

tsp implementation: https://github.com/Azure/azure-rest-api-specs/blob/141eb6d8c5aa89d50ab1b9a5c29b9c0886d10309/specifi…
swagger implementation: https://github.com/Azure/azure-rest-api-specs/blob/688609bf18c3978794a0c5ca31557c286c623b44/specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/preview/2024-12-09-preview/confidentialledger.json#L1057C35-L1057C48

Seems the service does accept the names in snake case (which is odd but worked before), but the issue is the fact that we're not wrapping with a "roles" object. Handwritten swaggers did have errors in them before.

[catalinaperalta]

@msyyc @iscai-msft an unblock for this issue would be much appreciated!

[msyyc]

@catalinaperalta their swagger definition https://github.com/Azure/azure-rest-api-specs/blob/688609bf18c3978794a0c5ca31557c286c623b44/specification/confidentialledger/data-plane/Microsoft.ConfidentialLedger/preview/2024-12-09-preview/confidentialledger.json#L1057C35-L1057C48 seems not right since they add a wrapper _json = {"roles": roles} manually in generated SDK code https://github.com/Azure/azure-sdk-for-python/blame/0674df4925cd2bfa5a56fa46417cbe16633298d9/sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_operations.py#L4148.

If the old SDK recording is right, then the swagger shall be:

    "Roles": {
      "description": "Definition for roles",
      "type": "object",
      "properties": {
        "roles": {
          "items": {
            "$ref": "#/definitions/Role"
          },
          "type": "array"
        }
      }
    },

And typespec shall be:

op createUserDefinedRole is ConfidentialLedgerCommon.LedgerOperation<
  {
    /** Request body */
    #suppress "@azure-tools/typespec-azure-core/request-body-problem" "Existing API contract"
    @bodyRoot
    roles: op createUserDefinedRole is ConfidentialLedgerCommon.LedgerOperation<
  {
    /** Request body */
    #suppress "@azure-tools/typespec-azure-core/request-body-problem" "Existing API contract"
    @bodyRoot
    roles: {roles: Role[]};
  },
  {}
>;
  },
  {}
>;