Use EsBuild instead of rollup for vscode #6676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
changed the title
|
You can try these changes here
|
…ode-use-esbuild-instead-of-rollup
…ode-use-esbuild-instead-of-rollup
timotheeguerin
requested review from
RodgeFu,
lirenhe,
bterlson,
markcowl,
allenjzhang,
chrisradek,
AlitzelMendez and
witemple-msft
as code owners
RodgeFu
reviewed
Mar 29, 2025
RodgeFu
reviewed
Mar 29, 2025
…ode-use-esbuild-instead-of-rollup
|
had a manual test pass and seems everything works. will you merge it? (I don't have permission to approve PR...) |
…ode-use-esbuild-instead-of-rollup
|
@RodgeFu did you loose permission to approve? |
chrisradek
approved these changes
Apr 8, 2025
chrisradek
approved these changes
Apr 8, 2025
Actually, I never had... Allen tried to add me to the contributor group before but failed because that group is full... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6370
Similar change done for prettier extension which is the only other thing still relying on rollup #6678
Still testing, but this simplify a lot and should get rid of all rollup deps having type issues and is much faster
Other change: