Skip to content

Fix using enum values in extension #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Fix using enum values in extension #6947

merged 3 commits into from
Apr 10, 2025

Conversation

timotheeguerin
Copy link
Member

fix #6695

this is doing a workaround until we resolve #3570 and can just call serializeValueAsJson

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/json-schema
  • ✅ @typespec/openapi
Show changes

@typespec/json-schema - fix ✏️

Fix crash when using enum values in extension

@typespec/openapi - fix ✏️

Fix crash when using enum values in extension

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 10, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

chrisradek
chrisradek approved these changes Apr 10, 2025
View reviewed changes
@timotheeguerin timotheeguerin added this pull request to the merge queue Apr 10, 2025
Merged via the queue into microsoft:main with commit 945bff4 Apr 10, 2025
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/enum-value-extensions branch April 10, 2025 20:42
@steverice steverice mentioned this pull request Jun 13, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a way to disable arg marshalling for decorators [Bug]: json-schema emitter fails on @extension value referencing an enum
3 participants
@timotheeguerin @azure-sdk @chrisradek