Fix telemetryClient initialization crash issue #7021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
RodgeFu,
lirenhe,
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
|
All changed packages have been documented.
|
|
You can try these changes here
|
timotheeguerin
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7020
After adopt esbuild to build the library, the rollup changed, it will crash when use
TelemetryReporteras constructor to initialize telemetry client. So update to useTelemetryReporter.defaultto refer to theTelemetryReporterclass and construct the instance. And apply try-catch so that it will not crash the whole process when exception occur during telemetry client initialization.