Skip to content

Fix @removed decorator causing an incorrect versioning failure #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Fix @removed decorator causing an incorrect versioning failure #7022

merged 3 commits into from
Apr 17, 2025

Conversation

AlitzelMendez
Copy link
Contributor

issue: #4964

@AlitzelMendez AlitzelMendez linked an issue Apr 17, 2025 that may be closed by this pull request
[Bug]: Certain versioning decorator fails when removed in later version #4964
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/versioning
Show changes

@typespec/versioning - fix ✏️

Fix issue where the incompatible-versioned-reference diagnostic was incorrectly triggered when a model had a @removed decorator and one of its properties had an @added decorator, even if the versions were compatible.,> ,> Example:,> tsp,> @removed(Versions.v3),> model Widget {,> @added(Versions.v2),> name: string;,> },>

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 17, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@AlitzelMendez AlitzelMendez marked this pull request as ready for review April 17, 2025 16:46
chrisradek
chrisradek requested changes Apr 17, 2025
View reviewed changes
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Apr 17, 2025
Merged via the queue into microsoft:main with commit 6fd17be Apr 17, 2025
22 checks passed
@AlitzelMendez AlitzelMendez deleted the fix-versioning-removed branch April 17, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Certain versioning decorator fails when removed in later version
4 participants
@AlitzelMendez @azure-sdk @timotheeguerin @chrisradek