Skip to content

typekits - support creating typekits with diagnostics #7049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 21, 2025
Merged

typekits - support creating typekits with diagnostics #7049

merged 15 commits into from
Apr 21, 2025

Conversation

chrisradek
Copy link
Member

Fixes #6973

chrisradek
chrisradek commented Apr 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/http
Show changes

@typespec/compiler - feature ✏️

Adds a new createDiagnosable typekit helper for APIs that return diagnostics

@typespec/http - feature ✏️

Updates $.httpOperation.get to be a diagnosable - use $.httpOperation.get.withDiagnostics to get diagnostics

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 18, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

timotheeguerin
timotheeguerin reviewed Apr 21, 2025
View reviewed changes
@chrisradek chrisradek mentioned this pull request Apr 21, 2025
Closed
3 tasks
@chrisradek chrisradek enabled auto-merge April 21, 2025 22:14
@chrisradek chrisradek linked an issue Apr 21, 2025 that may be closed by this pull request
[typekit] consider $.resolve #6963
Closed
3 tasks
@chrisradek chrisradek added this pull request to the merge queue Apr 21, 2025
Merged via the queue into microsoft:main with commit fe404bb Apr 21, 2025
22 checks passed
@chrisradek chrisradek deleted the typekits-diagnosable branch April 21, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeKit Diagnosable api [typekit] consider $.resolve
3 participants
@chrisradek @azure-sdk @timotheeguerin