Skip to content

[compiler] Add Tuple TypeKit #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 22, 2025
Merged

[compiler] Add Tuple TypeKit #7065

merged 11 commits into from
Apr 22, 2025

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Apr 21, 2025 •
edited
Loading

Resolves #6960

maorleger
maorleger commented Apr 21, 2025
View reviewed changes
maorleger
maorleger commented Apr 21, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/http
Show changes

@typespec/compiler - feature ✏️

Adds a TypeKit for Tuple types

@typespec/http - fix ✏️

Handle tuples without nodes

timotheeguerin
timotheeguerin reviewed Apr 21, 2025
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 21, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@maorleger maorleger marked this pull request as ready for review April 21, 2025 18:28
@maorleger maorleger mentioned this pull request Apr 21, 2025
Closed
@maorleger maorleger enabled auto-merge April 21, 2025 20:58
@maorleger maorleger disabled auto-merge April 21, 2025 21:48
maorleger
maorleger commented Apr 21, 2025
View reviewed changes
@maorleger maorleger enabled auto-merge April 22, 2025 14:42
@maorleger maorleger closed this Apr 22, 2025
auto-merge was automatically disabled April 22, 2025 15:34

Pull request was closed

@maorleger maorleger reopened this Apr 22, 2025
@maorleger maorleger enabled auto-merge April 22, 2025 15:36
@maorleger maorleger added this pull request to the merge queue Apr 22, 2025
Merged via the queue into microsoft:main with commit d300279 Apr 22, 2025
22 checks passed
@maorleger maorleger deleted the tuple-kits branch April 22, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson left review comments

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typekit] create $.tuple.* helpers
4 participants
@maorleger @azure-sdk @bterlson @timotheeguerin