Skip to content

Made 'Project' parameter positional on Start cmd #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2018
Merged

Made 'Project' parameter positional on Start cmd #102

merged 1 commit into from
Apr 27, 2018

Conversation

mister-liss
Copy link

@mister-liss mister-liss commented Apr 27, 2018 •
edited by jwittner
Loading

Resolves #97

@mister-liss mister-liss requested a review from jwittner April 27, 2018 20:57
jwittner
jwittner requested changes Apr 27, 2018
View reviewed changes
UnitySetup/UnitySetup.psm1 Outdated
@@ -733,7 +733,7 @@ function Get-UnityProjectInstance {
function Start-UnityEditor {
[CmdletBinding(SupportsShouldProcess, DefaultParameterSetName = "Context")]
param(
[parameter(Mandatory = $false, ValueFromPipeline = $true, ParameterSetName = 'Projects')]
[parameter(Mandatory = $false, ValueFromPipeline = $true, ParameterSetName = 'Projects', Position = 0)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to set the position for all the parameter sets it's involved in?

@jwittner
Copy link
Member

Worked great locally!

@jwittner jwittner merged commit f09d79c into microsoft:develop Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwittner jwittner jwittner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mister-liss @jwittner