Skip to content

add quotes around project path #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2019
Merged

add quotes around project path #141

merged 2 commits into from
Jan 15, 2019

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Jan 10, 2019 •
edited
Loading

Fixes #138 by adding quotes around project path within the argument string.

Example output:

VERBOSE: Performing the operation "Start-Process" on target "C:\Program
Files\Unity\Hub\Editor\2018.3.0f2\Editor\Unity.exe -projectPath "C:\Developer Projects\<ProjectRoot>\<UnityProject>\"".

StephenHodgson
StephenHodgson commented Jan 10, 2019
View reviewed changes
Ziugy
Ziugy approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@Ziugy Ziugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jwittner jwittner merged commit e8f5a0f into microsoft:develop Jan 15, 2019
@StephenHodgson StephenHodgson deleted the dev-project-path-whitespace branch January 15, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziugy Ziugy Ziugy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenHodgson @Ziugy @jwittner