Skip to content

Added lumin component installers #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 29, 2019
Merged

Added lumin component installers #148

merged 9 commits into from
Apr 29, 2019

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Jan 15, 2019

Note, this may not be availible until 2019 gets into beta or until we can download/install alpha builds, but I went ahead and did the preliminary work.

Fixes #147

@jwittner
Copy link
Member

Lets wait on this until UnitySetup can download versions that include the component.

@StephenHodgson
Copy link
Contributor Author

Agreed, just got started on the work for early feedback.

@StephenHodgson
Copy link
Contributor Author

@jwittner 2019 beta is out with accessible download components

@StephenHodgson
Copy link
Contributor Author

This PR is ready for review

@jwittner
Copy link
Member

jwittner commented Apr 1, 2019

Note: this will conflict with #161 .

@jwittner
Copy link
Member

jwittner commented Apr 1, 2019

I'll pull this down and test it out tomorrow. =)

@jwittner
Copy link
Member

jwittner commented Apr 1, 2019

Bah, UnitySetup throws an error if I search for 2019.1.0b9. New Issue here: #165

@StephenHodgson
Copy link
Contributor Author

This should be ready to test once the 2019 bugs are fixed.

# Conflicts:
#	UnitySetup/UnitySetup.psm1
Copy link
Member

@jwittner jwittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to find the installers for this new component, but I have concerns over the BuildTarget change.

@StephenHodgson
Copy link
Contributor Author

@jwittner, I was able to validate that the command like works! :shipit:

@jwittner jwittner merged commit e2100a8 into microsoft:develop Apr 29, 2019
@StephenHodgson StephenHodgson deleted the dev-lumin-component-installer branch April 30, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lumin component install support
2 participants