Fix hang with Start-UnityEditor -Quit -Wait #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had noticed this too but I couldn't pin it down. |
StephenHodgson
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is in the first commit - swapping out Start-Process for System.Diagnostics.Process.Start. For some reason Start-Process -Wait results in extra long waits after unity.exe has exited.
Current theory is that it's waiting for the handles to redirected output to close or a child process of unity.exe. Either way avoiding Start-Process -Wait has made the issue irreproducible.
The second commit includes auto-formatting that VS Code applied.