Skip to content

Add new cmdlet to test/report on meta file integrity #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

jwittner
Copy link
Member

Definitely open to arguments for a shorter name on this cmdlet. =)

@jwittner
Copy link
Member Author

Seeing errors converting the meta file for dlls - due to duplicate keys. Gonna try a work around.

@jwittner
Copy link
Member Author

Seeing errors converting the meta file for dlls - due to duplicate keys. Gonna try a work around.

This is fixed in latest, also now have progress reporting. =)

Copy link
Member

@derekfreed derekfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I found is that there is an unhandled case where filenames with [brackets] do not have their content found with get-content so the test results in metafiles with no associated content. This thought is a limitation of powershell 5 and below. This could be fixed in powershell 6 by using get-content -literalpath. In powershell 5 and below literlpath doe snot work with -exclude -include

@jwittner jwittner merged commit f82e085 into microsoft:develop Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants